Feat/fallback selector security check #85
Conversation
Changes to gas cost
🧾 Summary (5% most significant diffs)
Full diff report 👇
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #85 +/- ##
==========================================
+ Coverage 86.73% 86.78% +0.05%
==========================================
Files 35 35
Lines 769 772 +3
Branches 107 108 +1
==========================================
+ Hits 667 670 +3
Misses 88 88
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
contracts/base/ModuleManager.sol
Outdated
|
|
||
| // Revert if the selector is either `onInstall(bytes)` (0x6d61fe70) or `onUninstall(bytes)` (0x8a91b0e3) | ||
| // These selectors are forbidden as they can lead to security vulnerabilities | ||
| // and unexpected behavior during fallback handler installation. |
There was a problem hiding this comment.
can you describe what's the unexpected security behavior?
There was a problem hiding this comment.
"If it’s added a fallback method. Anyone can uninstall and reinstall the module. If it’s a validator, this will most likely pwn the account"
Feat/fallback selector security check
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
🤖 Slither Analysis Report 🔎Slither report
# Slither report
_This comment was automatically generated by the GitHub Actions workflow._
THIS CHECKLIST IS NOT COMPLETE. Use |
error FallbackSelectorForbidden();push